Skip to content

Consistently use shorter names: always use 'attrs', 'coords' and 'dims' #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 14, 2014
Merged

Consistently use shorter names: always use 'attrs', 'coords' and 'dims' #194

merged 4 commits into from
Aug 14, 2014

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Jul 31, 2014

Cleaned up a few cases where attributes was used instead of attrs in function signatures.

Fixes: #190

  • Switch names in xray itself
  • Switch names in tests
  • Switch names in documentation

@shoyer shoyer added this to the 0.2 milestone Jul 31, 2014
shoyer added 3 commits August 12, 2014 21:14
@shoyer
Consistent names: always use 'attrs' rather than 'attributes'
df30b55 
Related: pydata#190
@shoyer
Rename coordinates -> coords and dimensions -> dims
39f0d01 
The only breakage should be for anyone who has been using the
new DataArray constructor. Every other use of 'dimension' or 'coordinates'
should work but raise a FutureWarning.
@shoyer
Remove use of coordinates and dimensions in tests
34b5958
@shoyer shoyer changed the title Consistent names: always use 'attrs' rather than 'attributes' Consistently use shorter names: always use 'attrs', 'coords' and 'dims' Aug 13, 2014
shoyer added a commit that referenced this pull request Aug 14, 2014
@shoyer
Merge pull request #194 from shoyer/consistent-names
cd0ff19 
Consistently use shorter names: always use 'attrs', 'coords' and 'dims'
@shoyer shoyer merged commit cd0ff19 into pydata:master Aug 14, 2014
@shoyer shoyer deleted the consistent-names branch August 14, 2014 05:08
@shoyer shoyer mentioned this pull request Aug 14, 2014
Closed
keewis pushed a commit to keewis/xarray that referenced this pull request Jan 17, 2024
@TomNicholas
.to_dataset in map over subtree (pydata#194)
49f7a2f 
* tests

* use to_dataset instead of DatasetView in map_over_subtree

* no longer forbid initialising a DatasetView with init

* whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2
Development

Successfully merging this pull request may close these issues.

Consistent use of abbreviations: attrs, dims, coords
1 participant
@shoyer