Data objects now have a swappable backend store. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows conversion to and from: NetCDF4, scipy.io.netcdf and in memory storage. - Added general test cases, and cases for specific backend stores.
ghost
assigned 
|
In that case, planning to close this one? |
|
Nvm. Will review over the next day or two. |
|
Sounds good. I haven't had time to make much progress over the last few days, but do have some ideas about next steps and what this project has to offer that iris doesn't. I'll get both formalized next time I have a chance. In the meantime, feedback would be great! |
data.copy() is not implemented if data is a netCDF4 variable, and in any case it seems that we should always use views unless a copy is explicitly requested. Conflicts: src/polyglot/data.py
This makes it consistent with dataset.noncoordinates. If you want the old behavior (values as dimension lengths), then you can just use dataset.dimensions instead.
Conflicts: src/polyglot/data.py
Fixed most unit tests, test_translate_consistency still fails.
clarkfitzg
added a commit
that referenced
this pull request
Sep 4, 2015
don't show FacetGrid methods directly in API docs
shoyer
referenced
this pull request
in shoyer/xarray
Aug 6, 2017
Minor cleanup for Dataset.__getitem__
4 tasks
headtr1ck
added a commit
to headtr1ck/xarray
that referenced
this pull request
Dec 18, 2023
jhamman
pushed a commit
to jhamman/xarray
that referenced
this pull request
Oct 13, 2024
Fix test_roundtrip_empty_vlen_string_array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memory storage.