Skip to content

Fix/misc fixes #2426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 22, 2018
Merged

Fix/misc fixes #2426

merged 5 commits into from
Sep 22, 2018

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Sep 21, 2018

  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)

Some minor fixes.

  1. Don't explicitly set rotation on colorbar label. matplotlib automatically does the right thing for horizontal and vertical colorbars.

  2. Adds a test for whether an object is mappable before adding it to FacetGrid._mappables.

@shoyer
Copy link
Member

shoyer commented Sep 21, 2018

LGTM

@fmaussion can you take a quick look?

@fmaussion
Copy link
Member

Appart from a pep8 line length problem LGTM too!

Sitckler is on strike (#2428)

@dcherian dcherian merged commit 4577ed8 into pydata:master Sep 22, 2018
@dcherian dcherian deleted the fix/misc-fixes branch September 22, 2018 04:01
dcherian pushed a commit to dcherian/xarray that referenced this pull request Sep 23, 2018
* master:
  dev/test build for python 3.7 (pydata#2271)
  misc plotting fixes (pydata#2426)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants