Fix/misc fixes #2426
Merged
Fix/misc fixes #2426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 21, 2018 11:08
Labels work better with horizontal colorbar.
|
LGTM @fmaussion can you take a quick look? |
|
Appart from a pep8 line length problem LGTM too! Sitckler is on strike (#2428) |
dcherian
force-pushed
the
fix/misc-fixes
branch
from
71fadc4 to
7cb40ea
Compare
dcherian
pushed a commit
to dcherian/xarray
that referenced
this pull request
Sep 23, 2018
* master: dev/test build for python 3.7 (pydata#2271) misc plotting fixes (pydata#2426)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor fixes.
Don't explicitly set rotation on colorbar label. matplotlib automatically does the right thing for horizontal and vertical colorbars.
Adds a test for whether an object is mappable before adding it to
FacetGrid._mappables.