Refactor plot utils #2670
Merged
Refactor plot utils #2670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2019 00:48
1. refactor out _easy_facetgrid 2. Combine map_dataarray_line with map_dataarray
|
Hello @dcherian! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on January 30, 2019 at 16:44 Hours UTC |
* upstream/master: xfail cftimeindex multiindex test (pydata#2669) DOC: refresh "Why xarray" and shorten top-level description (pydata#2657) Remove broken Travis-CI builds (pydata#2661) Type checking with mypy (pydata#2655) Added Coarsen (pydata#2612)
|
Tests should pass after #2673 is fixed. |
shoyer
reviewed
Jan 14, 2019
dcherian
commented
Jan 15, 2019
shoyer
approved these changes
Jan 24, 2019
* master: stale requires a label (pydata#2701) Update indexing.rst (pydata#2700) add line break to message posted (pydata#2698) Config for closing stale issues (pydata#2684) to_dict without data (pydata#2659) Update asv.conf.json (pydata#2693) try no rasterio in py36 env (pydata#2691) Detailed report for testing.assert_equal and testing.assert_identical (pydata#1507) Hotfix for pydata#2662 (pydata#2678) Update README.rst (pydata#2682) Fix test failures with numpy=1.16 (pydata#2675)
dcherian
pushed a commit
that referenced
this pull request
Jan 30, 2019
commit 37a947a Author: Deepak Cherian <[email protected]> Date: Wed Jan 30 09:20:57 2019 -0800 Refactor plot utils (#2670) * Refactor out utility functions. * facetgrid refactor 1. refactor out _easy_facetgrid 2. Combine map_dataarray_line with map_dataarray * flake8 * Refactor out colorbar making to plot.utils._add_colorbar * Refactor out cmap_params, cbar_kwargs processing * Back to map_dataarray_line * lint * small rename * review comment. * Move _infer_line_data back. commit fd2552a Author: Spencer Clark <[email protected]> Date: Wed Jan 30 11:45:09 2019 -0500 Enable subtracting a scalar cftime.datetime object from a CFTimeIndex (#2672) * Enable subtracting a scalar cftime.datetime object from a CFTimeIndex * lint * Test cftime.datetime minus CFTimeIndex as well * Fix cftime minus CFTimeIndex commit e8bf4bf Author: Tom Nicholas <[email protected]> Date: Wed Jan 30 02:02:22 2019 +0000 Bugfix for line plot axes (#2726) * Fixed logic for setting line data * Added tests to check line data matches values of correct coords * Recorded bugfix for line plots * Update doc/whats-new.rst Co-Authored-By: TomNicholas <[email protected]> * Update doc/whats-new.rst Co-Authored-By: TomNicholas <[email protected]> commit 620b946 Author: Stephan Hoyer <[email protected]> Date: Sun Jan 27 13:02:03 2019 -0800 Fix test failures / warnings for pandas 0.24 (#2720) * Fix test failures / warnings for pandas 0.24 Fixes GH2717 * Brief doc note * Comment on name order commit 882deac Author: Stephan Hoyer <[email protected]> Date: Sun Jan 27 09:11:47 2019 -0800 DOC: refresh whats-new for 0.11.3 / 0.12.0 (#2718) commit 8ca8efe Author: Stephan Hoyer <[email protected]> Date: Sat Jan 26 10:14:49 2019 -0800 Update environment for doc build (#2708) * Update environment for doc build We were pinning very old versions for most of these packages. This should fix the failures on ReadTheDocs. * Build fixes commit 2e99c7d Author: Stephan Hoyer <[email protected]> Date: Fri Jan 25 13:52:17 2019 -0800 Print full environment fron conf.py (#2709) This should make it easier to debug the doc build environment. commit cc5015a Author: Stephan Hoyer <[email protected]> Date: Fri Jan 25 11:55:07 2019 -0800 BUG: ensure indexes are reset when coords are modified (#2707) This was introduced by the recent indexes refactor, but never made it into a release. commit aabda43 Author: Joe Hamman <[email protected]> Date: Fri Jan 25 08:38:45 2019 -0800 Remove py2 compat (#2645) * strip out PY2 compat code from pycompat.py * isort * remove 2 unused imports * remove extra import * no more future * no unicode literals * no more ReprMixin * cleanup merge * remove deprecated imports from collections * 2 more cleanups from shoyer
dcherian
pushed a commit
to yohai/xarray
that referenced
this pull request
Jan 30, 2019
* upstream/master: Refactor plot utils (pydata#2670) Enable subtracting a scalar cftime.datetime object from a CFTimeIndex (pydata#2672) Bugfix for line plot axes (pydata#2726) Fix test failures / warnings for pandas 0.24 (pydata#2720) DOC: refresh whats-new for 0.11.3 / 0.12.0 (pydata#2718) Update environment for doc build (pydata#2708) Print full environment fron conf.py (pydata#2709) BUG: ensure indexes are reset when coords are modified (pydata#2707) Remove py2 compat (pydata#2645)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the Dataset plotting PR smaller. This one