Open dataset cf options conflict solving #3544
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add tests for combinations of decode_cf and mask_and_scale * add tests for combinations of decode_cf and decode_times * add tests for combinations of decode_cf and concat_characters * add tests for non-conflicting options ofconcat_characters and decode_times relates to GH3020
Four default options of open_dataset() are changed from True to None in order to enable checks that a manual setting for `decode_cf` does not conflict with a manual setting of `mask_and_scale`, `decode_times`, `concat_characters`, or `decode_coords`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took some time*, but here is a suggestion to solve option conflicts in xarray.open_dataset().
If any of the options
mask_and_scale,decode_times,concat_characters, ordecode_coordsis manually set and contradicts the manually set choice ofdecode_cfaValueErrorwill be raised.This commit requires to change some option default values of open_dataset() parameters from
TruetoNone. I hope this is acceptable.black . && flake8(mypypasses in principle, but backends/api.py:21 has an unrelated error)whats-new.rstfor all changes andapi.rstfor new APIWhat do you think? Do I have to add something to
whats-new.rstandapi.rst?PS: (*) This is my first PR of this kind and I wanted to build it in a proper testing environment, but I had to set this up first.