Fix minor code quality issues #3626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Use `_` for unused variables - Use `"""` for docstrings - Add `.deepsource.toml` file to run continuous static analysis on repository with DeepSource
crusaderky
reviewed
Jan 30, 2020
.deepsource.toml
Outdated
|
|
||
| [analyzers.meta] | ||
| runtime_version = "3.x.x" | ||
| type_checker = "mypy" |
There was a problem hiding this comment.
Isn't this redundant with the Azure CI job we already have?
|
If you merge from master you should get all green on the upstream-dev test now |
|
Ok, I've played with it a bit and it's a hard -1 from me.
|
@sauravsrijan best of luck with your project, even if we won't be the first library to take this up
|
Merging these as helpful style changes (thank you @sauravsrijan ), even if we're not implementing DeepSource at the moment. We're open to reviewing in the future. |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Apr 5, 2020
* master: Use divergent colormap if lowest and highest level span 0 (pydata#3913) Bugfix for plotting transposed 2d coords (pydata#3934) Allow plotting bool data (pydata#3766) facetgrid: fix case when vmin == vmax (pydata#3916) add a CI that tests xarray with all optional dependencies but dask (pydata#3919) Add missing_dims argument allowing isel() to ignore missing dimensions (pydata#3923) Only fail if a specific warning occurs (pydata#3930) Fix minor code quality issues (pydata#3626) Fix for stack+groupby+apply w/ non-increasing coord (pydata#3906) reactivate the macos CI (pydata#3920) add pint to the output of show_versions() (pydata#3918)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
_for unused variables"""for docstrings.deepsource.tomlfile to run continuous static analysis on the repository with DeepSourceThis PR fixes some minor style issues and set up continuous static analysis on the repo with DeepSource. Upon enabling DeepSource, quality and security analysis will be run on every PR to detect 500+ types of problems in the changes — including bug risks, anti-patterns, security vulnerabilities, type-check issues, etc.
DeepSource is free to use for open-source projects, and is used by teams at NASA, Uber, Slack among many others, and open-source projects like ThoughtWorks/Gauge, Masonite Framework, etc.
To enable DeepSource analysis after merging this PR, please follow these steps: