Skip to content

[WIP] [DEMO] Add tests for ZipStore for zarr #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[WIP] [DEMO] Add tests for ZipStore for zarr #3888

wants to merge 2 commits into from

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk mentioned this pull request Mar 25, 2020
Open
@max-sixty
Copy link
Collaborator

My mistake re reproducibility per #3815 (comment)

@max-sixty max-sixty closed this Mar 25, 2020
@hmaarrfk
Copy link
Contributor Author

wouldn't this be a useful to test to have? I think the ability to save things in a zip store is quite useful.

@max-sixty
Copy link
Collaborator

Yes! But it fails? Otherwise I agree, moar tests...

@hmaarrfk
Copy link
Contributor Author

Alright, it probably makes more sense to reopen this when the issue gets fixed.

@max-sixty
Copy link
Collaborator

Great!
Alternatively if you want to surround it with xfail, reopen and we can merge....

@hmaarrfk
Copy link
Contributor Author

xfail just gets forgotten, so i'll leave it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmaarrfk @max-sixty