Skip to content

Pin pre-commit versions #4388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 31, 2020
Merged

Pin pre-commit versions #4388

merged 4 commits into from
Aug 31, 2020

Conversation

max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Aug 30, 2020

  • Passes isort . && black . && mypy . && flake8
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

I had some issues with the version changing — this approach seems more explicit and less likely to cause hard-to-debug issues

@keewis
Copy link
Collaborator

keewis commented Aug 30, 2020

To update we can use pre-commit autoupdate. Ideally, we would use the dependabot-like feature of the planned pre-commit CI which would automatically open PRs for us once there's a new version.

@max-sixty
Copy link
Collaborator Author

To update we can use pre-commit autoupdate. Ideally, we would use the dependabot-like feature of the planned pre-commit CI which would automatically open PRs for us once there's a new version.

Yes that'd be great; let's keep in touch with their progress there

@max-sixty max-sixty merged commit 55480de into pydata:master Aug 31, 2020
@max-sixty max-sixty deleted the pre-commit-pin branch August 31, 2020 16:31
@keewis keewis mentioned this pull request Feb 13, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants