Skip to content

fix KeyError when append_dim is not None in to_zarr for empty datastore #4531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

luoq
Copy link

@luoq luoq commented Oct 24, 2020

This bug is introduced in commit 1c5adc9

This should fix issue #4261

@shoyer
Copy link
Member

shoyer commented Oct 24, 2020

Thanks @luoq. Would it be possible to write test for this to ensure that we don't accidentally regress on this behavior again?

Also: #4035 touches this same code, and it would be nice to know if it fixes it or not.

@luoq
Copy link
Author

luoq commented Oct 25, 2020 via email

@dcherian
Copy link
Contributor

dcherian commented Dec 7, 2020

should be fixed by #4035

@dcherian dcherian closed this Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants