Skip to content

maint: pandas can now index with np.timedelta64 #4546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

mathause
Copy link
Collaborator

@mathause mathause commented Oct 28, 2020

pandas-dev/pandas#20393 was resolved in pandas version 0.23, so this should no longer be necessary. The relevant test is

array = DataArray(np.arange(365), [("delta", times - times[0])])
result = array.sel(delta=slice(array.delta[0], array.delta[-1]))
assert_equal(result, array)

so let's see if this passes

@mathause mathause merged commit ef910b9 into pydata:master Oct 30, 2020
@mathause mathause deleted the pd_index_np_timedelta64 branch October 30, 2020 10:32
@max-sixty
Copy link
Collaborator

Thanks @mathause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants