Skip to content

Port all the engines to apiv2 #4673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Dec 17, 2020
Merged

Port all the engines to apiv2 #4673

merged 17 commits into from
Dec 17, 2020

Conversation

aurghs
Copy link
Collaborator

@aurghs aurghs commented Dec 10, 2020

Port all the engines to the new API apiv2.
Note:

  • test_autoclose_future_warning has been removed because in apiv2.py autoclose has been removed

  • in open_backend_dataset_psedonetcdf currently is still used **format_kwargs and the signature is defined explicitly

  • Related to Flexible Backend - AbstractDataStore definition  #4309

  • Tests updated

  • Passes isort . && black . && mypy . && flake8

@pep8speaks
Copy link

pep8speaks commented Dec 10, 2020 •
edited
Loading

Hello @aurghs! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-17 13:11:12 UTC

@aurghs aurghs changed the title WIP: Port al the emngines to apiv2 WIP: Port all the engines to apiv2 Dec 10, 2020
alexamici
alexamici approved these changes Dec 16, 2020
View reviewed changes
@alexamici alexamici changed the title WIP: Port all the engines to apiv2 Port all the engines to apiv2 Dec 16, 2020
@shoyer shoyer merged commit 1386797 into pydata:master Dec 17, 2020
@aurghs aurghs mentioned this pull request Dec 21, 2020
Merged
2 tasks
@aurghs aurghs deleted the all-backend-as-plugings branch February 11, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexamici alexamici alexamici approved these changes

@shoyer shoyer shoyer approved these changes

Assignees
No one assigned
Labels
grant-czi topic-backends
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aurghs @pep8speaks @alexamici @shoyer