-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Allow pathlib.Path to be passed to all engines #4701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM @alexamici ! Could we add a small test / param onto an existing test? Or do you want to handle that as part of the larger PRs? |
@max-sixty there's no direct test for the backend Store classes, only indirect tests through Once we remove I propose to merge this PR as it is. |
Great! Thanks! |
Zarr's convenience methods accept Path objects as of 2.9.0: https://zarr.readthedocs.io/en/stable/release.html#enhancements |
isort . && black . && mypy . && flake8
Once
ZarrStore.open_group
andNetCDF4DataStore.open
acceptspathlib.Path
objects we can remove_normalize_path
fromapiv2.open_dataset
. All other backends accept them.Note that
zarr
itself doesn't support them, yet. See: zarr-developers/zarr-python#601