Skip to content

Combine='by_coords' and concat dim deprecation in open_mfdataset #5669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 1, 2021
Merged

Combine='by_coords' and concat dim deprecation in open_mfdataset #5669

merged 5 commits into from
Oct 1, 2021

Conversation

TomNicholas
Copy link
Member

@TomNicholas TomNicholas commented Aug 3, 2021 •
edited
Loading

Noticed this hadn't been completed in #5659

  • Tests added
  • Passes pre-commit run --all-files
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021 •
edited
Loading

Unit Test Results

         6 files           6 suites   56m 54s ⏱️
16 228 tests 14 494 ✔️ 1 734 💤 0 ❌
90 564 runs  82 385 ✔️ 8 179 💤 0 ❌

Results for commit 0e75d8c.

♻️ This comment has been updated with latest results.

mathause
mathause approved these changes Aug 5, 2021
View reviewed changes
Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just as a comment (of no direct relevance here) - there might be value in accepting (and using) the dim argument also for combine_by_coords as there may be ambiguous cases where it could help #4824 (comment).

@max-sixty max-sixty added the plan to merge Final call for comments label Aug 21, 2021
@TomNicholas
Copy link
Member Author

LGTM.

I've merged main, so will merge this as soon as the tests pass.

there might be value in accepting (and using) the dim argument also for combine_by_coords as there may be ambiguous cases where it could help #4824 (comment).

I don't think we should add dim to combine_by_coords - the whole philosophy of that function is that it uses only the information in the coordinates to do the combining. I would be more in favour of disallowing the arguments that lead to ambiguous outcomes. (But we should discuss this on #4824).

@TomNicholas TomNicholas merged commit 91d4d08 into pydata:main Oct 1, 2021
snowman2 pushed a commit to snowman2/xarray that referenced this pull request Feb 9, 2022
@TomNicholas @max-sixty
@mathause @snowman2
Combine='by_coords' and concat dim deprecation in open_mfdataset (pyd…
c7566af 
…ata#5669)

* deprecate

* test

* whats-new

* Update doc/whats-new.rst

Co-authored-by: Mathias Hauser <[email protected]>

Co-authored-by: Maximilian Roos <[email protected]>
Co-authored-by: Mathias Hauser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathause mathause mathause approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomNicholas @mathause @max-sixty