-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use .to_numpy() for quantified facetgrids #5886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1ddd3b2
to_numpy in facetgrid
TomNicholas c467046
to_numpy in 2D plots
TomNicholas 447721b
Merge branch 'main' into pr/5886
Illviljan d7d1cc2
test for faceted line plots
TomNicholas 3067a26
test and fix for faceted imshow
TomNicholas fca0bf2
check label of colorbar in faceted 2d plots
TomNicholas d2f060b
whatsnew
TomNicholas 19b5c68
Merge branch 'main' into quantified_facetgrids
TomNicholas 820c0fb
don't take values twice for masked arrays
TomNicholas baad9de
remove trailing whitespace
TomNicholas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite sure what needs to be done here with regards to converting between quantified arrays and masked arrays
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think it's already been done in this previous PR, which means
.to_masked_array
already dequantifieshttps://github.com/pydata/xarray/pull/5561/files#diff-386f35dda14ca12d315f2eb71f0ab35d7fdc73419b5dc5175ea5720f3206903bR2787
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... which means that calling
.as_numpy()
and then also calling.to_masked_array()
unneccessarily repeats calling.values
, so I got rid of the former.