Skip to content

Blacken notebooks #5890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2021
Merged

Blacken notebooks #5890

merged 1 commit into from
Oct 24, 2021

Conversation

max-sixty
Copy link
Collaborator

  • Passes pre-commit run --all-files

The new version of black formats notebook files too, so I was getting diffs when doing other work. This should let us upgrade black in pre-commit when that comes out

@keewis
Copy link
Collaborator

keewis commented Oct 23, 2021

that's already possible, we just need to add - id: black-jupyter to the hooks of the black repo

@github-actions
Copy link
Contributor

Unit Test Results

         6 files           6 suites   53m 23s ⏱️
16 230 tests 14 506 ✔️ 1 724 💤 0
90 576 runs  82 408 ✔️ 8 168 💤 0

Results for commit 01b0953.

@max-sixty max-sixty merged commit dd1fffd into pydata:main Oct 24, 2021
@max-sixty
Copy link
Collaborator Author

that's already possible, we just need to add - id: black-jupyter to the hooks of the black repo

Ah! I'll do this

@max-sixty max-sixty deleted the blacken-notebooks branch October 24, 2021 00:29
snowman2 pushed a commit to snowman2/xarray that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants