-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add pyupgrade onto pre-commit #6152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I haven't tried this locally but does it slow down the local runs noticeably? Might be annoying for those who do local pre-commits in that case. But it fits great for the CI and since the bot will autocorrect now I think it outweighs the cons.
One can always turn off the local pre-commit and rely on the CI instead if it becomes to annoying.
We might need to merge the part of #6024 that deactivates |
These ones are fast! |
whats-new.rst
This auto-fixes problems, so the bar to add it on is low...