Skip to content

Allow decoding of size-0 datetimes #6882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 10, 2022
Merged

Allow decoding of size-0 datetimes #6882

merged 5 commits into from
Aug 10, 2022

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Aug 5, 2022

@dcherian dcherian requested a review from spencerkclark August 5, 2022 21:00
dcherian
dcherian commented Aug 5, 2022
View reviewed changes
@spencerkclark spencerkclark mentioned this pull request Aug 6, 2022
Closed
dcherian
dcherian commented Aug 8, 2022
View reviewed changes
spencerkclark
spencerkclark approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@spencerkclark spencerkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dcherian! This looks good to me.

@dcherian dcherian added the plan to merge Final call for comments label Aug 9, 2022
@dcherian dcherian merged commit f8fee90 into pydata:main Aug 10, 2022
@dcherian dcherian deleted the fix/1329 branch October 18, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerkclark spencerkclark spencerkclark approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot open NetCDF file if dimension with time coordinate has length 0 (ValueError when decoding CF datetime)
2 participants
@dcherian @spencerkclark