Allow empty DataFrame in Dataset construction #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess I thought an empty DataFrame should correspond to an empty Dataset? I agree that this makes more sense, though. |
|
The empty <-> empty does make sense actually. I think either would be OK... |
shoyer
added a commit
that referenced
this pull request
Jan 2, 2016
Allow empty DataFrame in Dataset construction
|
This is definitely more consistent -- for example, imagine slicing a DataFrame into different sizes, converting each group into a Dataset and then concatenation. Thanks! You get big kudos for deleting code but adding a test :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #697
@shoyer: am I missing something as to why the special case was there?