Skip to content

Pandas 2.2.0 test fixes #8638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 22, 2024
Merged

Pandas 2.2.0 test fixes #8638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
888c5c3
Fix doc building following breaking change in Pandas 2.2.0
nameloCmaS Jan 21, 2024
3f8ad6b
Further fixes for changed Pandas 2.2 date aliases
nameloCmaS Jan 21, 2024
ccf1a62
Merge remote-tracking branch 'upstream/main' into pandas-2.2.0-doc-fix
nameloCmaS Jan 21, 2024
fb70add
Update test_cftime_offsets.py
nameloCmaS Jan 22, 2024
d6084f8
Update whats-new.rst
nameloCmaS Jan 22, 2024
779ba65
Update dataarray.py
nameloCmaS Jan 22, 2024
f9b1403
Update test_accessor_dt.py
nameloCmaS Jan 22, 2024
f29beff
Update test_cftime_offsets.py
nameloCmaS Jan 22, 2024
288facf
Merge branch 'main' into pandas-2.2.0-doc-fix
max-sixty Jan 22, 2024
6d866c1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 22, 2024
7962dca
Merge branch 'pandas-2.2.0-doc-fix' of https://github.com/nameloCmaS/…
nameloCmaS Jan 22, 2024
90613a9
Update _aggregations.py
nameloCmaS Jan 22, 2024
b445f47
Update whats-new.rst
nameloCmaS Jan 22, 2024
31b5ed9
Update generate_aggregations.py
nameloCmaS Jan 22, 2024
aaaab45
Merge branch 'pandas-2.2.0-doc-fix' of https://github.com/nameloCmaS/…
nameloCmaS Jan 22, 2024
5cdf81d
Update _aggregations.py
nameloCmaS Jan 22, 2024
e9a1641
Update whats-new.rst
nameloCmaS Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions doc/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7270,11 +7270,16 @@ Breaking changes
- The ``season`` datetime shortcut now returns an array of string labels
such `'DJF'`:

.. ipython:: python
:okwarning:
.. code-block:: ipython

ds = xray.Dataset({"t": pd.date_range("2000-01-01", periods=12, freq="M")})
ds["t.season"]
In[92]: ds = xray.Dataset({"t": pd.date_range("2000-01-01", periods=12, freq="M")})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this switch to ME? (We'll see in the docs build, so can wait if you're not sure)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "code-block" part and then the ":: ipython" above the code means it is static but with syntax highlighting. Doc.

I did this as I didn't want to "change history" and my quick fix of :okwarning: was not ok. The code was correct at v0.4 so shouldn't be refactored to run on modern code.


In[93]: ds["t.season"]
Out[93]:
<xarray.DataArray 'season' (t: 12)>
array(['DJF', 'DJF', 'MAM', ..., 'SON', 'SON', 'DJF'], dtype='<U3')
Coordinates:
* t (t) datetime64[ns] 2000-01-31 2000-02-29 ... 2000-11-30 2000-12-31

Previously, it returned numbered seasons 1 through 4.
- We have updated our use of the terms of "coordinates" and "variables". What
Expand Down
2 changes: 1 addition & 1 deletion xarray/backends/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1433,7 +1433,7 @@ def save_mfdataset(

>>> ds = xr.Dataset(
... {"a": ("time", np.linspace(0, 1, 48))},
... coords={"time": pd.date_range("2010-01-01", freq="M", periods=48)},
... coords={"time": pd.date_range("2010-01-01", freq="ME", periods=48)},
... )
>>> ds
<xarray.Dataset>
Expand Down
Loading