-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add torch_geometric.nn.attention to docs
#10089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xnuohz
commented
Mar 1, 2025

akihironitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Could we have a similar list to the list of conv layers?
Convolutional Layers
--------------------
.. currentmodule:: torch_geometric.nn.conv
.. autosummary::
:nosignatures:
:toctree: ../generated
:template: autosummary/nn.rst
{% for name in torch_geometric.nn.conv.classes %}
{{ name }}
{% endfor %}
|
there are too many conv modules, if list all the details, i think searching will be inconvenient. |
akihironitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wdym? nn.attention has 4 layers:
$ git grep "class " torch_geometric/nn/attention/
torch_geometric/nn/attention/performer.py:class PerformerProjection(torch.nn.Module):
torch_geometric/nn/attention/performer.py:class PerformerAttention(torch.nn.Module):
torch_geometric/nn/attention/qformer.py:class QFormer(torch.nn.Module):
torch_geometric/nn/attention/sgformer.py:class SGFormerAttention(torch.nn.Module):
|
misread it to expand all the conv modules haha |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10089 +/- ##
==========================================
- Coverage 86.11% 85.16% -0.95%
==========================================
Files 496 510 +14
Lines 33655 35954 +2299
==========================================
+ Hits 28981 30622 +1641
- Misses 4674 5332 +658 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@akihironitta fixed webinar url and added docstring for llm wrappers, lmk if anything else to merge |
puririshi98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM