Skip to content

Conversation

@xnuohz
Copy link
Contributor

@xnuohz xnuohz commented Mar 1, 2025

image

Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could we have a similar list to the list of conv layers?

Convolutional Layers
--------------------

.. currentmodule:: torch_geometric.nn.conv

.. autosummary::
   :nosignatures:
   :toctree: ../generated
   :template: autosummary/nn.rst

   {% for name in torch_geometric.nn.conv.classes %}
     {{ name }}
   {% endfor %}

@xnuohz
Copy link
Contributor Author

xnuohz commented Mar 1, 2025

there are too many conv modules, if list all the details, i think searching will be inconvenient.

Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdym? nn.attention has 4 layers:

$ git grep "class " torch_geometric/nn/attention/
torch_geometric/nn/attention/performer.py:class PerformerProjection(torch.nn.Module):
torch_geometric/nn/attention/performer.py:class PerformerAttention(torch.nn.Module):
torch_geometric/nn/attention/qformer.py:class QFormer(torch.nn.Module):
torch_geometric/nn/attention/sgformer.py:class SGFormerAttention(torch.nn.Module):

@xnuohz
Copy link
Contributor Author

xnuohz commented Mar 1, 2025

misread it to expand all the conv modules haha

@codecov
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.16%. Comparing base (c211214) to head (7b3f1bb).
⚠️ Report is 142 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10089      +/-   ##
==========================================
- Coverage   86.11%   85.16%   -0.95%     
==========================================
  Files         496      510      +14     
  Lines       33655    35954    +2299     
==========================================
+ Hits        28981    30622    +1641     
- Misses       4674     5332     +658     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xnuohz
Copy link
Contributor Author

xnuohz commented Mar 4, 2025

@akihironitta fixed webinar url and added docstring for llm wrappers, lmk if anything else to merge

@xnuohz xnuohz requested a review from akihironitta May 6, 2025 16:51
Copy link
Contributor

@puririshi98 puririshi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@puririshi98 puririshi98 merged commit 5ab0833 into pyg-team:master Sep 9, 2025
18 checks passed
@xnuohz xnuohz deleted the docs/nn branch September 9, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants