Skip to content

Conversation

@xnuohz
Copy link
Contributor

@xnuohz xnuohz commented Mar 5, 2025

  • Combine 15 examples related to cora into 1 file
  • Update related docs, github workflow, readme

@xnuohz xnuohz requested review from a team, EdisonLeeeee, rusty1s and wsad1 as code owners March 5, 2025 12:51
Copy link
Contributor

@puririshi98 puririshi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good at first review, but for such an extensive change i would ask that you run every one of the deleted examples, and then the new version with its corresponding args for this planetoid example. I would ask that you share those logs and also check yourself to make sure that the new version is as good or better in terms of accuracy, speed, and readability. and if not for any reason try to understand why. This is a very valuable PR but we want to be careful with something like this.

If compute is an issue, i would ask that you write a bash script for me that will automatically run the above experiments and have the logs saved to some shared cloud drive or a github repo so you can do the above mentioned anlaysis after i run the script.

regardless once you have said analysis, i will look through myself as well and make sure our analyses align. then i think this is safe to merge

@puririshi98
Copy link
Contributor

also please update the changelog

Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far! ✨

Tbh, I'd vote for having many separate 90~100 lines of code examples to allow users to immediately understand what the script does and easily modify the scirpt that they're interested in (at the cost of maintaining duplicate code in the example directory), but I guess this is just my preference.

Could we also add type annotations?

@codecov
Copy link

codecov bot commented Mar 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.43%. Comparing base (c211214) to head (16d1fdc).
⚠️ Report is 94 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10097      +/-   ##
==========================================
- Coverage   86.11%   85.43%   -0.68%     
==========================================
  Files         496      496              
  Lines       33655    34007     +352     
==========================================
+ Hits        28981    29055      +74     
- Misses       4674     4952     +278     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@puririshi98 puririshi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM once you address my one comment, but curious what @akihironitta thinks now. from our PoV in the longrun it is good to have unified code snippets for testing and customer use. the new planetoid_train.py offers that while explaining what old examples it combines

Copy link
Contributor

@puririshi98 puririshi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see you swapped example -> example1 in severl places, can you explain why?

Copy link
Contributor

@puririshi98 puririshi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just ask that @akihironitta give a final stamp of approval

@puririshi98
Copy link
Contributor

closing based on matthias's decision to not merge

@xnuohz xnuohz deleted the examples/cleanup branch May 31, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants