-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add stale workflow #10146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stale workflow #10146
Conversation
Kh4L
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding this workflow!
30 days might be a bit too strict
how about 60 days?
|
@Kh4L thanks for the review:)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10146 +/- ##
==========================================
- Coverage 86.11% 85.43% -0.68%
==========================================
Files 496 496
Lines 33655 34007 +352
==========================================
+ Hits 28981 29055 +74
- Misses 4674 4952 +278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
this LGTM, @akihironitta @rusty1s thoughts? |
akihironitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
|
@akihironitta thanks for the review, all resolved. |
|
closing based on matthias's decision to not merge |
for fun, feel free to merge or close