Skip to content

Conversation

@xnuohz
Copy link
Contributor

@xnuohz xnuohz commented Mar 27, 2025

for fun, feel free to merge or close

Copy link
Contributor

@Kh4L Kh4L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this workflow!

30 days might be a bit too strict
how about 60 days?

@xnuohz
Copy link
Contributor Author

xnuohz commented Mar 28, 2025

@Kh4L thanks for the review:)
will change it to 60d, 2 more questions:

  1. should also apply it to pr? current it’s closed.
  2. what other labels need to be included in stale? current only bug

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.43%. Comparing base (c211214) to head (6beb0cc).
⚠️ Report is 94 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10146      +/-   ##
==========================================
- Coverage   86.11%   85.43%   -0.68%     
==========================================
  Files         496      496              
  Lines       33655    34007     +352     
==========================================
+ Hits        28981    29055      +74     
- Misses       4674     4952     +278     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puririshi98
Copy link
Contributor

this LGTM, @akihironitta @rusty1s thoughts?

Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

xnuohz and others added 5 commits May 29, 2025 20:52
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
@xnuohz
Copy link
Contributor Author

xnuohz commented May 29, 2025

@akihironitta thanks for the review, all resolved.

@puririshi98
Copy link
Contributor

closing based on matthias's decision to not merge

@xnuohz xnuohz deleted the workflows/stale branch May 31, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants