Skip to content

TXT2KG refactor v2 config + vanillaRAG #10252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 7, 2025

Conversation

Kh4L
Copy link
Contributor

@Kh4L Kh4L commented May 6, 2025

No description provided.

Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 6.89655% with 27 lines in your changes missing coverage. Please review.

Please upload report for BASE (txt2kg-v2@875e40e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
torch_geometric/nn/models/g_retriever.py 0.00% 25 Missing ⚠️
torch_geometric/utils/rag/backend_utils.py 50.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (6.89%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             txt2kg-v2   #10252   +/-   ##
============================================
  Coverage             ?   84.28%           
============================================
  Files                ?      500           
  Lines                ?    34567           
  Branches             ?        0           
============================================
  Hits                 ?    29134           
  Misses               ?     5433           
  Partials             ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kh4L Kh4L changed the title TXT2KG refactor v2 config TXT2KG refactor v2 config + vanillaRAG May 6, 2025
Copy link
Contributor

@puririshi98 puririshi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@puririshi98 puririshi98 marked this pull request as ready for review May 6, 2025 19:40
@puririshi98 puririshi98 merged commit 5254403 into pyg-team:txt2kg-v2 May 7, 2025
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants