Remove colordict, rework parsing color from string #3461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, while on the surface it doesn't seem bad, I don't think this change is available in the way you are proposing it fully. You are effectively removing a documented and type-hinted constant, breaking compatibility. A github search shows that a very big chunk of people's code use that constant, check for yourself: |
|
This PR cannot be merged as it is for reasons damus stated. Though it would be fine if you also implement some "dict proxy" class that can compat the existing dict. In my opinion this is too much work though, it would be instead better to wait for a breaking release and do this PR then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes colordict module, moves parsing color from string to C code, didn't check for the speed, but this should improve memory usage. Also need to find the right way to test this change
Fix #1664