depend: improve Windows pylib detection #4204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow pylib detection when VERSION.dll is a dependency of python.exe rather than pythonXY.dll If libpython is not detected uses the dependency checker to look for a dll matching the pattern pythonXY.dll using the same method as automated detection. Checks after automated detection and only on windows systems. Fixes #3942
Author
|
@bjones1 any ideas why the CI fails? This PR contains https://github.com/karolyi/pyinstaller/commit/824559fb0f25c14e599650c1662e882e06aa0efd. |
Contributor
Author
|
Nope, that commit is still breaking the CI. See #3956 (comment) |
Contributor
|
Apologies, I did not see the discussion on the issue. Hopefully pip 19.1.1 will be released soon and no pinning will be necessary anymore: pypa/pip#6449 |
Contributor
|
Thanks for your contribution! I merged this in 80941bc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow pylib detection when VERSION.dll is a dependency of python.exe
rather than pythonXY.dll
If libpython is not detected uses the dependency checker to look for a
dll matching the pattern pythonXY.dll using the same method as
automated detection.
Checks after automated detection and only on windows systems.
Fixes #3942
Refers #3956