Skip to content

[maintenance] Drop the brain for nose #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[maintenance] Drop the brain for nose #2765

wants to merge 6 commits into from
+4 −128

Conversation

Pierre-Sassoulas
Copy link
Member

Description

The faster way to fix the pipeline.

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Jun 11, 2025
@DanielNoord
Copy link
Collaborator

Pipeline still fails 😄

What's the error we're fixing?

@Pierre-Sassoulas
Copy link
Member Author 

 ERROR tests/brain/test_nose.py - UserWarning: pkg_resources is deprecated as an API. 
See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package
 is slated for removal as early as 2025-11-30. Refrain from using this package or pin to 
Setuptools<81.

Seen here: #2763

@DanielNoord
Copy link
Collaborator

@Pierre-Sassoulas I would be okay with removing a brain for a package that has not had a release since 2015. nose is no longer actively maintained and rarely used, I believe. See also https://github.com/nose-devs/nose

@Pierre-Sassoulas
Copy link
Member Author

Right, supporting nose but not pydantic, is a little backward

@Pierre-Sassoulas Pierre-Sassoulas added this to the 4.0.0 milestone Jun 11, 2025
@Pierre-Sassoulas Pierre-Sassoulas changed the title [packaging] Temporarily limit setuptools to < 81 [maintenance] Drop the brain for nose Jun 11, 2025
Pierre-Sassoulas
Pierre-Sassoulas commented Jun 11, 2025
View reviewed changes
DanielNoord
DanielNoord previously approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your suggestion for the changelog, rest LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Documentation 📗 Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Pierre-Sassoulas @DanielNoord