Skip to content

Fixed conditional import x.y causing possibly-used-before-assignment #10240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

alexprabhat99
Copy link
Contributor

Type of Changes

Type
🐛 Bug fix

Description

Refs #XXXX

Closes #10081

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.85%. Comparing base (abb8187) to head (2d69243).
Report is 128 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10240   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files         175      175           
  Lines       19056    19056           
=======================================
  Hits        18267    18267           
  Misses        789      789           
Files with missing lines Coverage Δ
pylint/checkers/variables.py 97.28% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 2d69243

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jacobtylerwalls jacobtylerwalls merged commit 7b28cf4 into pylint-dev:main Feb 20, 2025
46 checks passed
Copy link
Contributor

The backport to maintenance/3.3.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/3.3.x maintenance/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/3.3.x
# Create a new branch
git switch --create backport-10240-to-maintenance/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7b28cf474796ecfb875c3c812e30865222623e41
# Push it to GitHub
git push --set-upstream origin backport-10240-to-maintenance/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/3.3.x

Then, create a pull request where the base branch is maintenance/3.3.x and the compare/head branch is backport-10240-to-maintenance/3.3.x.

jacobtylerwalls pushed a commit to jacobtylerwalls/pylint that referenced this pull request Feb 20, 2025
jacobtylerwalls added a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conditional import X.Y causes false positive possibly-used-before-assignment
2 participants