Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ Release date: TBA

Closes #3614

* Fix crash with ``AssignAttr`` in ``if TYPE_CHECKING`` blocks.

Closes #5111


What's New in Pylint 2.11.1?
============================
Expand Down
4 changes: 3 additions & 1 deletion pylint/checkers/variables.py
Original file line number Diff line number Diff line change
Expand Up @@ -1536,7 +1536,9 @@ def _is_variable_violation(
for definition in defstmt_parent.orelse:
if isinstance(definition, nodes.Assign):
defined_in_or_else = any(
target.name == name for target in definition.targets
target.name == name
for target in definition.targets
if isinstance(target, nodes.AssignName)
)
if defined_in_or_else:
break
Expand Down
10 changes: 10 additions & 0 deletions tests/functional/u/undefined/undefined_variable.py
Original file line number Diff line number Diff line change
Expand Up @@ -328,3 +328,13 @@ def decorated3(x):
@decorator(x * x * y for x in range(3)) # [undefined-variable]
def decorated4(x):
print(x)


# https://github.com/PyCQA/pylint/issues/5111
# AssignAttr in orelse block of 'TYPE_CHECKING' shouldn't crash
# Name being assigned must be imported in orelse block
if TYPE_CHECKING:
pass
else:
from types import GenericAlias
object().__class_getitem__ = classmethod(GenericAlias)