fix(numba): non-contiguous shared variable #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseyboldt
force-pushed
the
fix-numba-fortran-order
branch
from
4a731c0 to
27d69da
Compare
Shared variables (ie pm.Data) that were non-contiguous could lead to incorrect results in the pymc numba backend. We now ensure that they are always c-contiguous by copying if they are not.
aseyboldt
force-pushed
the
fix-numba-fortran-order
branch
from
27d69da to
18e5a07
Compare
ricardoV94
reviewed
May 28, 2025
| @@ -256,7 +256,7 @@ def _compile_pymc_model_numba( | |||
| for val in [*logp_fn_pt.get_shared(), *expand_fn_pt.get_shared()]: | |||
| if val.name in shared_data and val not in seen: | |||
| raise ValueError(f"Shared variables must have unique names: {val.name}") | |||
| shared_data[val.name] = val.get_value() | |||
| shared_data[val.name] = np.array(val.get_value(), order="C", copy=True) | |||
There was a problem hiding this comment.
if you're copying anyway you can do get_value(borrow=True) to avoid doing 2 copies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://discourse.pymc.io/t/nutpie-panel-data-events-moving/17046/5 for more details
Shared variables (ie pm.Data) that were non-contiguous could lead to incorrect results in the pymc numba
backend.
We now ensure that they are always c-contiguous by copying if they are not.