Skip to content

Gallery #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 31, 2022
Merged

Gallery #328

merged 7 commits into from
May 31, 2022

Conversation

twiecki
Copy link
Member

@twiecki twiecki commented May 26, 2022

Using a hack to only use the parts of nbsphinx that are required for the gallery but does not clash with myst_nb.

Closes #327.

Related: executablebooks/MyST-NB#396
Hack from: PlasmaPy/PlasmaPy#1474 (comment)

I couldn't yet figure out how to get it to work with md files rather than rst. I also couldn't figure out how to make it look only for *-ipynb files, it only worked with *.

@OriolAbril do you have an idea?

image

@OriolAbril
Copy link
Member

This looks promising, thanks!

I couldn't yet figure out how to get it to work with md files rather than rst.

Using rst for this page is not an issue, the notebooks continue to be jupyter notebooks which is the important part.

I also couldn't figure out how to make it look only for *-ipynb files, it only worked with *.

We can look into that, but it might be easier to just get rid of the python scripts mixed in there. Python scripts don't appear on the website nor make the list in the github traffic section which means that at most they get 5 visits a month. Otherwise they would appear in this traffic page. If some script is very important is should be made into a notebook, otherwise it is as if it didn't exist and will end up being removed at some point.

I'll try to take a better look next week and see if we can get the images to work and maybe also 4 columns in the thumbnails

@twiecki
Copy link
Member Author

twiecki commented May 30, 2022

Also allows to address #160.

@twiecki
Copy link
Member Author

twiecki commented May 31, 2022

So this isn't done yet, thumbnails aren't working. And the code is WIP, but it compiles for me locally and can be merged until I figure out thumbnails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement nbsphinx gallery
2 participants