Skip to content

notebook: GLM Poisson regression, update header and footer #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 1, 2022

Conversation

reshamas
Copy link
Contributor

References

#DataUmbrellaPyMCSprint

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@cluhmann cluhmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

# GLM: Poisson Regression

:::{post} November 12, 2022
:tags: regression, poisson
:category: Intermediate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flying dove in the preview: https://pymcio--462.org.readthedocs.build/projects/examples/en/462/generalized_linear_models/GLM-poisson-regression.html is not green because tagss and categories are case sensitive. it should be everything lowercase.

@@ -489,7 +500,7 @@ posterior_predictive = model.predict(inf_fish_alt, kind="pps")

We can use `az.plot_ppc()` to check that the posterior predictive samples are similar to the observed data.

For more information on posterior predictive checks, we can refer to https://docs.pymc.io/notebooks/posterior_predictive.html.
For more information on posterior predictive checks, we can refer to {class}`pymc.posterior_predictive`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For more information on posterior predictive checks, we can refer to {class}`pymc.posterior_predictive`.
For more information on posterior predictive checks, we can refer to {ref}`pymc:posterior_predictive`.

@reshamas reshamas requested review from OriolAbril and cluhmann and removed request for drbenvincent and canyon289 November 30, 2022 19:31
Copy link
Member

@cluhmann cluhmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks even better!

@OriolAbril OriolAbril merged commit f3594b5 into pymc-devs:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants