Skip to content

[DRAFT] Notebook: GLM out-of-sample; initial update #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

reshamas
Copy link
Contributor

@reshamas reshamas commented Dec 6, 2022

References

Helpful links

Notes for the Reviewer

#DataUmbrellaPyMCSprint

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@twiecki
Copy link
Member

twiecki commented Dec 7, 2022

Missing the myst file.

@twiecki
Copy link
Member

twiecki commented Dec 7, 2022

Actually as this uses the GLM submodule exclusively, which does not exist anymore, we should probably just get rid of this NB.

@reshamas
Copy link
Contributor Author

reshamas commented Dec 7, 2022

@twiecki
The notebook still works with pymc v3.

Should we open up an issue to create a new notebook for pymc v4 with an out-of-sample example?

@twiecki
Copy link
Member

twiecki commented Dec 7, 2022

I don't think we need to invest in v3 docs.

We have https://www.pymc.io/projects/examples/en/latest/howto/data_container.html#using-data-container-variables-to-predict-on-new-data so I think it's fine.

@reshamas
Copy link
Contributor Author

reshamas commented Dec 7, 2022

Note to self: delete the notebook and submit a PR.

@reshamas
Copy link
Contributor Author

reshamas commented Dec 7, 2022

@twiecki Trying to figure out how to relate issue #460 to this PR.

cc: @juanitorduz @drbenvincent

@juanitorduz
Copy link
Collaborator

hey! there was an updated version of this notebook :) See #460 (comment)

@OriolAbril
Copy link
Member

This is something users struggle with a lot, so I'd aim for keeping the v4 version of this notebook

@drbenvincent
Copy link
Contributor

I've brought back the v3 -> v4 conversion that I did this summer. It got removed by accident, see #460 for more details. I've run this using pymc 5.0.1 now, so probably recommend we close this in favour of #486.

@drbenvincent
Copy link
Contributor

#486 is merged now, so closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants