Skip to content

Remove pin of SciPy 1.8.0 once we run Aesara 2.4.0 #5448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelosthege opened this issue Feb 6, 2022 · 1 comment · Fixed by #5474
Closed

Remove pin of SciPy 1.8.0 once we run Aesara 2.4.0 #5448

michaelosthege opened this issue Feb 6, 2022 · 1 comment · Fixed by #5474
Labels
bug installation issues about dependencies or installation v3 v4
Milestone
v4.0.0

Comments

@michaelosthege
Copy link
Member

Description of your problem

There's a new SciPy release 1.8.0 and they refactored their public/private API.

https://github.com/scipy/scipy/releases/tag/v1.8.0

Aesara has some import incompatibilities and this is causing our CIs to fail.

Related Aesara issue: aesara-devs/aesara#810

The incompatibility will most probably affect v3 too, so we'll want to backport a pin of the upper SciPy version.

Versions and main components

  • PyMC/PyMC3 Version: <=3.11.4, <=4.0.0b2
  • Aesara/Theano Version: all <=2.3.8
@michaelosthege michaelosthege added bug v4 v3 installation issues about dependencies or installation labels Feb 6, 2022
@michaelosthege michaelosthege modified the milestones: v4.0.0b3, v4.0.0 Feb 6, 2022
@michaelosthege michaelosthege mentioned this issue Feb 6, 2022
Merged
@michaelosthege michaelosthege mentioned this issue Feb 6, 2022
Merged
michaelosthege added a commit to michaelosthege/pymc that referenced this issue Feb 6, 2022
@michaelosthege
Pin ranges for NumPy and SciPy
4691af7 
Version ranges for NumPy and SciPy were aligned between all CI envs.
Since Theano-PyMC is incompatible with the new SciPy 1.8.0,
this upper limit will most likely stay for all `v3` versions.

See tracking issue pymc-devs#5448.
ricardoV94 pushed a commit to michaelosthege/pymc that referenced this issue Feb 15, 2022
@michaelosthege @ricardoV94
Temporarily pin SciPy to <1.8.0
060cfdf 
See tracking issue pymc-devs#5448.
ricardoV94 pushed a commit that referenced this issue Feb 15, 2022
@michaelosthege @ricardoV94
Temporarily pin SciPy to <1.8.0
d018cba 
See tracking issue #5448.
@ricardoV94
Copy link
Member

ricardoV94 commented Feb 15, 2022 •
edited
Loading

The temporary pin can be removed once we update our Aesara dependency (pending #5446)

@twiecki twiecki changed the title Import errors with SciPy 1.8.0 Remove pin of SciPy 1.8.0 once we run Aesara 2.4.0 Feb 15, 2022
@michaelosthege michaelosthege mentioned this issue Feb 15, 2022
Merged
ricardoV94 pushed a commit to michaelosthege/pymc that referenced this issue Feb 22, 2022
@michaelosthege @ricardoV94
Upgrade Aesara version pin and unpin SciPy upper limit
0a7d966 
Closes pymc-devs#5446
Closes pymc-devs#5448
michaelosthege added a commit that referenced this issue Feb 27, 2022
@michaelosthege
Upgrade Aesara version pin and unpin SciPy upper limit
b09805a 
Closes #5446
Closes #5448
@yihong0618 yihong0618 mentioned this issue Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug installation issues about dependencies or installation v3 v4
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

Upgrade Aesara version pin and unpin SciPy upper limit michaelosthege/pymc
2 participants
@michaelosthege @ricardoV94