-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove NormalMixture comp_shape kwarg #6986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ricardoV94 Can you elaborate this issue more,I wish to contribute to this issue. |
@ricardoV94, in version 3.x it used to be necessary to supply the component distribution shape. This could be used to do weird things like making multivariate mixture components out of scalar distributions (what I mean is that the shape of the support dimensions could effectively be changed). As far as I understand, this is no longer the case since version 4.x. Mixtures reshape their component batch dimensions so that they broadcast correctly with the mixture shape, and there is no way of changing the sport dimensions. |
Thanks for the context Luciano! We may reintroduce something like that later down the road but for now seems safe to remove the useless kwarg |
@mohammed052 sorry for the delay. If you are still interested, it's as simple as removing any mentions of pymc/pymc/distributions/mixture.py Lines 496 to 560 in 2051d0b
|
Thank you @ricardoV94 and @lucianopaz for explanation of the issue and its solution |
Yes, that's about it |
If it's your first time, you may find this guide useful: https://www.pymc.io/projects/docs/en/latest/contributing/pr_tutorial.html |
@ricardoV94 can you review the pull request I sent on 11th jan for closing this issue |
Description
This has no effect besides what shape already does
CC @lucianopaz do you remember why this existed? I imagine it had something to do with the old way that weight used to work.
The text was updated successfully, but these errors were encountered: