Skip to content

Don't broadcast in alltrue #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2016
Merged

Don't broadcast in alltrue #1452

merged 1 commit into from
Oct 14, 2016

Conversation

AustinRochford
Copy link
Member

Addresses #1449

@AustinRochford
Copy link
Member Author

@twiecki test_alltrue_shape fails on the current master and passes on this branch

@twiecki
Copy link
Member

twiecki commented Oct 14, 2016

Nice, looks simple (and logical) enough. I trust it wasn't as straightforward to derive at that solution though.

@AustinRochford
Copy link
Member Author

It was pretty simple--the hardest part was getting the tests to pass locally (even on master).

@twiecki
Copy link
Member

twiecki commented Oct 14, 2016

So even the geweke passes locally for you now?

@twiecki twiecki merged commit 1b7b4bb into pymc-devs:master Oct 14, 2016
@twiecki twiecki mentioned this pull request Oct 14, 2016
Closed
@AustinRochford
Copy link
Member Author

Yes, on Python 3.5 with the conda env created by create_testenv.sh. Still does not pass on Python 2.7 locally, though.

@twiecki
Copy link
Member

twiecki commented Oct 14, 2016

Travis at least didn't have a problem on 2.7.

This was referenced Oct 14, 2016
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AustinRochford @twiecki