Skip to content

Skip test triggering fixture error. #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rpgoldman
Copy link
Contributor

Fixes #3775... only without really fixing it.

@rpgoldman rpgoldman requested a review from ferrine January 19, 2020 17:33
Because of a pytest issue these trigger issue pymc-devs#3775.
@rpgoldman rpgoldman force-pushed the disable-broken-test branch from 4de626d to c847909 Compare January 20, 2020 02:58
@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #3776 into master will increase coverage by 6.91%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3776      +/-   ##
==========================================
+ Coverage   83.65%   90.57%   +6.91%     
==========================================
  Files         133      133              
  Lines       20336    20337       +1     
==========================================
+ Hits        17013    18421    +1408     
+ Misses       3323     1916    -1407
Impacted Files Coverage Δ
pymc3/tests/test_variational_inference.py 95.74% <100%> (+95.74%) ⬆️
pymc3/model.py 89.17% <0%> (+0.12%) ⬆️
pymc3/tests/helpers.py 56.6% <0%> (+1.88%) ⬆️
pymc3/distributions/shape_utils.py 100% <0%> (+11.11%) ⬆️
pymc3/memoize.py 96.15% <0%> (+13.46%) ⬆️
pymc3/variational/opvi.py 85.29% <0%> (+17.28%) ⬆️
pymc3/variational/callbacks.py 95.91% <0%> (+18.36%) ⬆️
pymc3/variational/inference.py 78.65% <0%> (+22.47%) ⬆️
pymc3/variational/operators.py 92.68% <0%> (+36.58%) ⬆️
pymc3/variational/approximations.py 80.25% <0%> (+42.03%) ⬆️
... and 7 more

@ferrine
Copy link
Member

ferrine commented Jan 20, 2020

I've created #3779 that hopefully solves the issue. I have to close this one as it is located in your pymc3 fork that I can't work with

@ferrine ferrine closed this Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_fit_oo[ADVI-full] test is broken
2 participants