Skip to content

Pandas 1.0 compatibility: to_numpy() instead of as_matrix() #3794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2020

Conversation

michaelosthege
Copy link
Member

Over in #3784 my pipeline broke because of the pandas 1.0 release.

This PR fixes the incompatibilities that caused the tests to fail.

@codecov
Copy link

codecov bot commented Feb 1, 2020

Codecov Report

Merging #3794 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3794      +/-   ##
=========================================
+ Coverage   90.69%   90.7%   +0.01%     
=========================================
  Files         133     133              
  Lines       20368   20368              
=========================================
+ Hits        18472   18475       +3     
+ Misses       1896    1893       -3
Impacted Files Coverage Δ
pymc3/glm/utils.py 68.96% <66.66%> (ø) ⬆️
pymc3/tests/test_step.py 100% <0%> (+0.4%) ⬆️
pymc3/tests/test_mixture.py 99.65% <0%> (+0.69%) ⬆️

@michaelosthege michaelosthege changed the title Pandas 1.0 compatibility: values() instead of as_matrix() Pandas 1.0 compatibility: to_numpy() instead of as_matrix() Feb 1, 2020
@michaelosthege michaelosthege merged commit 80237a1 into pymc-devs:master Feb 1, 2020
@lucianopaz
Copy link
Contributor

Thanks @michaelosthege!

sthagen added a commit to sthagen/pymc-devs-pymc that referenced this pull request Feb 2, 2020
use to_numpy() instead of as_matrix() (pymc-devs#3794)
@michaelosthege michaelosthege deleted the pandas-1.0-fixes branch August 7, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants