-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Test on oldest supported versions during end-to-end CI #4374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
841d45e
test on oldest supported versions during end-to-end CI
MarcoGorelli 2d80633
less strict pin
MarcoGorelli 5dfa487
try 1.15 pin
MarcoGorelli 04ed835
try pinning pandas and scipy too
MarcoGorelli 3d2ad33
Merge remote-tracking branch 'upstream/master' into fixup-ci
MarcoGorelli 727d8ca
Merge remote-tracking branch 'upstream/master' into fixup-ci
MarcoGorelli 5fbc4c4
only test betabinom if scipy modern enough
MarcoGorelli b24745d
Merge remote-tracking branch 'upstream/master' into fixup-ci
MarcoGorelli d939eef
revert sort_conda changes (will do in separate PR)
MarcoGorelli 96e2882
generate requirements-dev from py37 env
MarcoGorelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,7 +42,7 @@ repos: | |
name: Check no tests are ignored | ||
pass_filenames: false | ||
- id: conda-env-sort | ||
additional_dependencies: [pyyaml] | ||
additional_dependencies: [ruamel.yaml] | ||
entry: python scripts/sort_conda_envs.py | ||
files: ^conda-envs/ | ||
language: python | ||
|
@@ -51,7 +51,7 @@ repos: | |
- id: pip-from-conda | ||
additional_dependencies: [pyyaml] | ||
entry: python scripts/generate_pip_deps_from_conda.py | ||
files: ^conda-envs/ | ||
files: ^conda-envs/environment-dev-py37\.yml$ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's probably a good idea to have some CI jobs run with different versions of packages, to check PyMC3 works both with the oldest and with the newest versions of its dependencies. So, requirements-dev.txt now has to be generated from just one yml file |
||
language: python | ||
name: Generate pip dependency from conda | ||
- id: no-relative-imports | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ | |
h5py>=2.7 | ||
ipython>=7.16 | ||
nbsphinx>=0.4 | ||
numpy==1.13.0 | ||
numpydoc>=0.9 | ||
pre-commit>=2.8.0 | ||
pytest-cov>=2.5 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ruamel.yaml
preserves comments (whichpyyaml
destroys) so switching to thatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do this in a separate PR