Bring back tests #4512
Merged
Bring back tests #4512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelosthege
force-pushed
the
bing-back-tests
branch
from
07259d8 to
cc0e681
Compare
michaelosthege
force-pushed
the
bing-back-tests
branch
2 times, most recently
from
6c7b715 to
89206da
Compare
michaelosthege
force-pushed
the
bing-back-tests
branch
from
89206da to
9e99ee3
Compare
twiecki
reviewed
Mar 9, 2021
| @@ -323,6 +325,7 @@ def system(y, t, p): | |||
| assert trace["y0"].size > 0 | |||
| assert trace["sigma"].size > 0 | |||
|
|
|||
| @pytest.mark.xfail(reason="HalfCauchy was not yet refactored") | |||
There was a problem hiding this comment.
Why "was"? Shouldn't that be "is"?
There was a problem hiding this comment.
I guess you're right 🙃
But for the sake of moving forward I'd like to not rebase/force-push again, unless something else comes up.
twiecki
reviewed
Mar 9, 2021
| @@ -271,7 +272,7 @@ def test_full_adapt_sampling(seed=289586): | |||
| L[np.triu_indices_from(L, 1)] = 0.0 | |||
|
|
|||
| with pymc3.Model() as model: | |||
| pymc3.MvNormal("a", mu=np.zeros(len(L)), chol=L, shape=len(L)) | |||
| pymc3.MvNormal("a", mu=np.zeros(len(L)), chol=L, size=len(L)) | |||
There was a problem hiding this comment.
Do we not support shape anymore?!
There was a problem hiding this comment.
twiecki
approved these changes
Mar 9, 2021
brandonwillard
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables large parts of the test suite.
Tests that are very broken are still ignored. Many of them use APIs that were completely removed; others have just too many errors to go in and XFAIL them right now.
One job runs test files that pass without a single XFAIL 🎉
And another job runs those that have some XFAILs.
I also added a config setting for pytest to treat
XPASSas failures. This way we'll know when things get fixed! For example a lot of tests will turn green as soon asMvNormalgot refactored.