Remove float128 dtype #4514
Merged
Remove float128 dtype #4514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersions and furthermore does not to be properly supported even if it does exist.
michaelosthege
approved these changes
Mar 9, 2021
Member
michaelosthege
left a comment
michaelosthege
left a comment
There was a problem hiding this comment.
Fair enough.
I'm a bit surprised that only 3 files had to be changed. Did you search the entire project for "float128"?
Member
Author
|
I did. |
ethervoid
pushed a commit
to ethervoid/pymc3
that referenced
this pull request
Jul 1, 2021
* Remove float128 dtype which does not exist on Windows and newer OSX versions and furthermore does not to be properly supported even if it does exist. * Add float128 to release-notes. Add link to memoization PR. * Remove unused imports.
|
@michaelosthege could be possible to backport this change to the v3? Right now is only in v4 and you can get some problems if you're using an Apple M1 |
Member
|
@ethervoid see #4834 |
michaelosthege
pushed a commit
to michaelosthege/pymc
that referenced
this pull request
Jul 5, 2021
Backport of pymc-devs#4514. Removes float128 dtype which does not exist on Windows and newer OSX versions and furthermore does not to be properly supported even if it does exist.
twiecki
added a commit
that referenced
this pull request
Jul 5, 2021
Backport of #4514. Removes float128 dtype which does not exist on Windows and newer OSX versions and furthermore does not to be properly supported even if it does exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not exist on Windows and newer OSX versions and furthermore does not to be properly supported even if it does exist: https://stackoverflow.com/questions/29820829/cannot-use-128bit-float-in-python-on-64bit-architecture
Closes #4513.
Thank your for opening a PR!
Depending on what your PR does, here are a few things you might want to address in the description: