Skip to content

Removed temporary pin of Aesara version #4978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

kc611
Copy link
Contributor

@kc611 kc611 commented Sep 2, 2021

Fixes #4961

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #4978 (8ba09f4) into main (78b1380) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4978   +/-   ##
=======================================
  Coverage   74.11%   74.12%           
=======================================
  Files          86       86           
  Lines       13876    13876           
=======================================
+ Hits        10284    10285    +1     
+ Misses       3592     3591    -1     
Impacted Files Coverage Δ
pymc3/aesaraf.py 91.26% <100.00%> (ø)
pymc3/step_methods/hmc/base_hmc.py 91.05% <0.00%> (+0.81%) ⬆️

@kc611
Copy link
Contributor Author

kc611 commented Sep 2, 2021

The current test failure in pymc3/tests/test_ode.py::TestDiffEqModel::test_scalar_ode_2_param looks flaky (possibly unrelated). I'm unable to replicate it locally.

@twiecki
Copy link
Member

twiecki commented Sep 2, 2021

Thanks @kc611! Rerunning tests.

@twiecki twiecki merged commit 73e76d3 into pymc-devs:main Sep 2, 2021
@ricardoV94
Copy link
Member

This commit could be reverted: 78b1380

@twiecki
Copy link
Member

twiecki commented Sep 2, 2021

Cool, lets do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aesara 2.2.0 release broke tests on main
3 participants