-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
More moments #5025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
More moments #5025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc02117
to
22dc2ad
Compare
22dc2ad
to
1c8726c
Compare
1c8726c
to
6bdf269
Compare
2 tasks
6bdf269
to
f7a278e
Compare
Codecov Report
@@ Coverage Diff @@
## main #5025 +/- ##
==========================================
- Coverage 77.85% 77.81% -0.05%
==========================================
Files 128 128
Lines 24349 24380 +31
==========================================
+ Hits 18958 18972 +14
- Misses 5391 5408 +17
|
69ae04c
to
012f595
Compare
Co-authored-by: Adrian Seyboldt <[email protected]>
012f595
to
beb5bb9
Compare
twiecki
reviewed
Sep 25, 2021
lucianopaz
reviewed
Sep 25, 2021
lucianopaz
reviewed
Sep 25, 2021
twiecki
reviewed
Sep 25, 2021
twiecki
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds get_moment implementations and tests them more thoroughly.