Skip to content

Fix rvs_to_value_vars inplace update bug #5186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ricardoV94
Copy link
Member

Fixes #5172

@ricardoV94 ricardoV94 force-pushed the fix_rvs_to_value_vars_inplace_bug branch from d5abf71 to e662bba Compare November 15, 2021 15:13
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #5186 (3c9f3ef) into main (b9b9efc) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5186      +/-   ##
==========================================
+ Coverage   78.09%   78.13%   +0.04%     
==========================================
  Files          88       88              
  Lines       14176    14203      +27     
==========================================
+ Hits        11071    11098      +27     
  Misses       3105     3105              
Impacted Files Coverage Δ
pymc/aesaraf.py 90.24% <100.00%> (+0.13%) ⬆️
pymc/distributions/continuous.py 96.52% <0.00%> (+0.06%) ⬆️
pymc/distributions/multivariate.py 71.72% <0.00%> (+0.24%) ⬆️

@ricardoV94 ricardoV94 force-pushed the fix_rvs_to_value_vars_inplace_bug branch from e662bba to 3c9f3ef Compare November 16, 2021 08:16
@ricardoV94 ricardoV94 merged commit 7840581 into pymc-devs:main Nov 16, 2021
@ricardoV94 ricardoV94 deleted the fix_rvs_to_value_vars_inplace_bug branch November 18, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling rvs_to_value_vars modifies model.free_RVs
3 participants