Skip to content

Remove windows xfails #5249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Dec 8, 2021

Tests were passing locally on my machine, just a sanity check that they still fail here

It seems they are passing. Somehow the strict XFAIL was not triggered?

Closes #4904

@ricardoV94 ricardoV94 marked this pull request as ready for review December 8, 2021 18:49
@ricardoV94 ricardoV94 added maintenance tests winOS windows OS related labels Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #5249 (36477ad) into main (7191e61) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5249      +/-   ##
==========================================
- Coverage   78.98%   78.97%   -0.01%     
==========================================
  Files          88       88              
  Lines       14231    14231              
==========================================
- Hits        11240    11239       -1     
- Misses       2991     2992       +1     
Impacted Files Coverage Δ
pymc/step_methods/hmc/base_hmc.py 90.32% <0.00%> (-0.81%) ⬇️

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardoV94
Copy link
Member Author

Surprisingly enough the strict was raising when I tested locally one at a time

@michaelosthege
Copy link
Member

I saw a discussion in the pytest issues about changes to the meaning/scope of the --strict option. There might be a change in behavior that crept in with a newer pytest version a d becomes effective because we're running specific test files?

@ricardoV94 ricardoV94 merged commit f32c039 into pymc-devs:main Dec 8, 2021
@ricardoV94 ricardoV94 deleted the try_removing_windows_ode_xfails branch January 31, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scalar ODEs on Windows failing because of a casting & broadcastability issue that was fixed only for Linux
2 participants