Skip to content

LKJCorr and LKJCholeskyCov refactor #5382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 28, 2022
Merged

LKJCorr and LKJCholeskyCov refactor #5382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f534a7f
Rename `BaseTestDistribution` to `BaseTestDistributionRandom`
ricardoV94 Jan 24, 2022
346daa1
Test expected (inferred) and actual shape of draws in `TestBaseDistri…
ricardoV94 Jan 24, 2022
2daa766
Update aesara dependency to 2.3.8
ricardoV94 Jan 25, 2022
5fd94ca
Refactor LKJCorr distribution to V4
ricardoV94 Jan 24, 2022
eed60c3
Add LKJCorr moment
ricardoV94 Jan 24, 2022
1a35a3d
Refactor LKJCholeskyCov for V4
ricardoV94 Jan 25, 2022
6f13f7e
Add LKJCholeskyCov moment
ricardoV94 Jan 25, 2022
45bbc9e
Reenable old MvNormal tests
ricardoV94 Jan 25, 2022
5f43bb4
Reenable old MatrixNormal test
ricardoV94 Jan 25, 2022
8666bbc
Make `TestMvNormalMisc.test_issue_3758` bound less strict
ricardoV94 Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ All of the above apply to:
- ArviZ `plots` and `stats` *wrappers* were removed. The functions are now just available by their original names (see [#4549](https://github.com/pymc-devs/pymc/pull/4471) and `3.11.2` release notes).
- `pm.sample_posterior_predictive(vars=...)` kwarg was removed in favor of `var_names` (see [#4343](https://github.com/pymc-devs/pymc/pull/4343)).
- `ElemwiseCategorical` step method was removed (see [#4701](https://github.com/pymc-devs/pymc/pull/4701))
- `LKJCholeskyCov` `compute_corr` keyword argument is now set to `True` by default (see[#5382](https://github.com/pymc-devs/pymc/pull/5382))

### Ongoing deprecations
- Old API still works in `v4` and has a deprecation warning.
Expand Down
2 changes: 1 addition & 1 deletion conda-envs/environment-dev-py37.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ channels:
- defaults
dependencies:
- aeppl=0.0.18
- aesara=2.3.6
- aesara=2.3.8
- arviz>=0.11.4
- cachetools>=4.2.1
- cloudpickle
Expand Down
2 changes: 1 addition & 1 deletion conda-envs/environment-dev-py38.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ channels:
- defaults
dependencies:
- aeppl=0.0.18
- aesara=2.3.6
- aesara=2.3.8
- arviz>=0.11.4
- cachetools>=4.2.1
- cloudpickle
Expand Down
2 changes: 1 addition & 1 deletion conda-envs/environment-dev-py39.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ channels:
- defaults
dependencies:
- aeppl=0.0.18
- aesara=2.3.6
- aesara=2.3.8
- arviz>=0.11.4
- cachetools>=4.2.1
- cloudpickle
Expand Down
2 changes: 1 addition & 1 deletion conda-envs/environment-test-py37.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ channels:
- defaults
dependencies:
- aeppl=0.0.18
- aesara=2.3.6
- aesara=2.3.8
- arviz>=0.11.4
- cachetools>=4.2.1
- cloudpickle
Expand Down
2 changes: 1 addition & 1 deletion conda-envs/environment-test-py38.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ channels:
- defaults
dependencies:
- aeppl=0.0.18
- aesara=2.3.6
- aesara=2.3.8
- arviz>=0.11.4
- cachetools>=4.2.1
- cloudpickle
Expand Down
2 changes: 1 addition & 1 deletion conda-envs/environment-test-py39.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ channels:
- defaults
dependencies:
- aeppl=0.0.18
- aesara=2.3.6
- aesara=2.3.8
- arviz>=0.11.4
- cachetools
- cloudpickle
Expand Down
2 changes: 1 addition & 1 deletion conda-envs/windows-environment-dev-py38.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ channels:
dependencies:
# base dependencies (see install guide for Windows)
- aeppl=0.0.18
- aesara=2.3.6
- aesara=2.3.8
- arviz>=0.11.4
- cachetools>=4.2.1
- cloudpickle
Expand Down
2 changes: 1 addition & 1 deletion conda-envs/windows-environment-test-py38.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ channels:
dependencies:
# base dependencies (see install guide for Windows)
- aeppl=0.0.18
- aesara=2.3.6
- aesara=2.3.8
- arviz>=0.11.2
- cachetools
- cloudpickle
Expand Down
Loading