Revert "Refactoring _print_name for certain RVs and specifying rv_type in their distributions" #6249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
added
the
no releasenotes
github-actions
bot
removed
the
no releasenotes
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6249 +/- ##
===========================================
- Coverage 93.77% 78.46% -15.32%
===========================================
Files 101 101
Lines 22232 22184 -48
===========================================
- Hits 20849 17407 -3442
- Misses 1383 4777 +3394
|
…e in their distributions" This reverts commit 652c9de
ricardoV94
force-pushed
the
revert_subclasses
branch
from
e6d95fa to
3030d3b
Compare
ricardoV94
changed the title
ricardoV94
added
the
no releasenotes
larryshamalama
approved these changes
Oct 27, 2022
twiecki
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 652c9de
After discussing with @larryshamalama, it does not seem these changes fix the thing we were originally trying to fix in the still open #6149, and we will probably proceed with a dispatch strategy instead of subclass then.
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance