Only add total_size mapping to observed RVs
#6331
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add direct test * Add checks for when it's not applicable * Rename mapping to `observed_rvs_to_total_sizes`
ricardoV94
changed the title
total_size mapping to observed RVs
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6331 +/- ##
===========================================
- Coverage 90.39% 63.23% -27.17%
===========================================
Files 111 110 -1
Lines 23869 23966 +97
===========================================
- Hits 21577 15154 -6423
- Misses 2292 8812 +6520
|
|
Superseded by #6523 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes inconsistent use of the
rvs_to_total_sizesmapping. It only assigns observed_RVs to it, including the observed component of an imputed variable (even though that is not allowed at the moment).It also raises if passed to
free_RVsDocs / Maintenance
total_sizeinterface