Optional McBackend support - #6510
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6510 +/- ##
==========================================
- Coverage 91.91% 83.06% -8.86%
==========================================
Files 89 148 +59
Lines 14936 28018 +13082
==========================================
+ Hits 13729 23272 +9543
- Misses 1207 4746 +3539
|
michaelosthege
force-pushed
the
optional-mcb
branch
2 times, most recently
from
February 11, 2023 22:37
c659bc6 to
68862bd
Compare
ricardoV94
marked this pull request as ready for review
February 13, 2023 17:54
michaelosthege
commented
Feb 13, 2023
michaelosthege
force-pushed
the
optional-mcb
branch
4 times, most recently
from
February 20, 2023 11:23
7178efb to
0b425f5
Compare
michaelosthege
force-pushed
the
optional-mcb
branch
4 times, most recently
from
February 23, 2023 00:50
4e31a43 to
8f81dfa
Compare
michaelosthege
force-pushed
the
optional-mcb
branch
4 times, most recently
from
February 26, 2023 16:50
6ce32a0 to
75f7053
Compare
michaelosthege
force-pushed
the
optional-mcb
branch
from
February 26, 2023 17:44
75f7053 to
345e3ce
Compare
ricardoV94
approved these changes
Feb 28, 2023
Member
Author
|
Whoopsie, are you aware that the last commit changed the default for situations where McBackend is installed? |
Member
|
I don't think we should change the default yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements optional support for McBackend based trace backends.
This builds on top of the refactorings from #6475 that decoupled the
pm.samplingmodule fromBaseTrace.I split the addition of McBackend support into two commits, the first of which makes the necessary code changes without actually adding McBackend as a dependency for the test environments just to confirm that the optional importing works.
The
mcbackend.RunMetaobject that is created by themake_runmetafunction contains several important metadata about the current model variables. This includes information such as whether a variable is deterministic or not. Related issues:Checklist
New features
pm.sample(trace=...)now acceptsmcbackend.Backendinstances.