Implement check_icdf helper to test icdf implementations
#6583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6583 +/- ##
==========================================
- Coverage 92.03% 92.02% -0.02%
==========================================
Files 92 92
Lines 15539 15561 +22
==========================================
+ Hits 14302 14320 +18
- Misses 1237 1241 +4
|
ricardoV94
force-pushed
the
improve_check_parameters
branch
from
6b7da71 to
48a8765
Compare
michaelosthege
approved these changes
Mar 10, 2023
|
Didn't notice some tests were failing |
ricardoV94
force-pushed
the
improve_check_parameters
branch
3 times, most recently
from
7cf8312 to
3464fe4
Compare
ricardoV94
force-pushed
the
improve_check_parameters
branch
from
3464fe4 to
b1b12c8
Compare
ricardoV94
force-pushed
the
improve_check_parameters
branch
from
b1b12c8 to
006e0f9
Compare
Note that adding a nan switch to the icdf expression of discrete variables, prevents the returned dtype to be the same as the original distribution. There is no integer nan!
ricardoV94
force-pushed
the
improve_check_parameters
branch
from
006e0f9 to
9ef9a14
Compare
michaelosthege
approved these changes
Mar 13, 2023
michaelraczycki
added a commit
to michaelraczycki/pymc
that referenced
this pull request
Mar 18, 2023
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For use in #6528
Also cleaned up the
check_logplike helpersCC @michaelraczycki