-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add type hints to distribution parameters #6635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add some type hints
#DataUmbrellaPyMCSprint |
This looks good to me. The one omission is |
Thank you for the feedback. I will make the necessary changes. |
@cluhmann I have added more type hints to distribution parameters and typed the Wald distribution as you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. I am going to approve this to get the workflows working and then we can see where things are at. Someone should sanity check the changes just to make sure I haven't missed anything before merging.
I lied (I'm not qualified). Can someone review so we can see how all the CI shakes out? |
Note: This PR was submitted using Gitpod! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6635 +/- ##
==========================================
- Coverage 91.96% 89.33% -2.63%
==========================================
Files 94 94
Lines 15927 15927
==========================================
- Hits 14647 14229 -418
- Misses 1280 1698 +418
|
If I am reading the log correctly, this seems to be some plotting/Tcl error on windows? Does that have anything to do with this PR? |
If it's the GP plot test it crops up now and then. No idea why |
Ah. That seems to be it.
|
What is this PR about?
...Added type hints to distribution parameters
issue #5358
#DataUmbrellaPyMCSprint
@reshamas @cluhmann @SangamSwadiK
Checklist
Documentation
📚 Documentation preview 📚: https://pymc--6635.org.readthedocs.build/en/6635/